MVJ-111 upload attachments to custom directory [RETRY]

[NC-jsAhonen]

All file fields are made into PrivateFileFields that have a custom file storage configured to them. The default for local settings is to save them to the codebase root under the /attachments/ directory, but the ATTACHMENTS_LOCATION and ATTACHMENTS_BASE_URL settings determine where the files will be stored.

[NC-jsAhonen]

For some reason, the CI fails because of this false positive. The migrations mentioned on the logs have been removed. I wonder if this is an outdated cache issue.

Run python manage.py makemigrations --dry-run --check
  python manage.py makemigrations --dry-run --check
  python manage.py migrate
  shell: /usr/bin/bash -e {0}
  env:
    DATABASE_URL: ***localhost/github_actions
    pythonLocation: /opt/hostedtoolcache/Python/3.10.16/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.16/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.16/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.16/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.16/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.16/x64/lib
Migrations for 'forms':
  forms/migrations/0028_alter_attachment_attachment.py
    - Alter field attachment on attachment
Migrations for 'leasing':
  leasing/migrations/0090_alter_collectioncourtdecision_file_and_more.py
    - Alter field file on collectioncourtdecision
    - Alter field file on collectionletter
    - Alter field file on collectionlettertemplate
    - Alter field file on infilldevelopmentcompensationattachment
    - Alter field file on inspectionattachment
    - Alter field file on landuseagreementattachment
    - Alter field file on leaseareaattachment
Migrations for 'plotsearch':
  plotsearch/migrations/0043_alter_areasearchattachment_attachment_and_more.py
    - Alter field attachment on areasearchattachment
    - Alter field meeting_memo on meetingmemo

[henrinie-nc]

No base url is needed

[henrinie-nc]

No base url needed

[henrinie-nc]

I would consider adding the location in the init of this class, since it is something we do not want to be configurable for this storage

[henrinie-nc]

Looks good