Convert JWT amr to list if string #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I am not 100% sure if this is still an issue. If this has been fixed in Tunnistamo already, then this PR is probably redundant and should be closed. I go with the assumption that this is still a "feature" in Tunnistamo. |
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 51.80% 51.94% +0.14%
==========================================
Files 30 30
Lines 1000 1003 +3
==========================================
+ Hits 518 521 +3
Misses 482 482
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akikoskinen
suggested changes
Mar 22, 2023
danipran
force-pushed
the
convert-amr-to-list
branch
from
84e0706 to
848a621
Compare
danipran
force-pushed
the
convert-amr-to-list
branch
from
fbb6644 to
c735af7
Compare
akikoskinen
suggested changes
Mar 30, 2023
|
Oh yeah, I apparently failed at amending commits 🤡 |
Apparently, this screws things up if drf-oidc-auth is below 1.0.0. drf-oidc-auth >=1.0.0 is required for Django 4, however. Bit of a workaround, but should work? Source: City-of-Helsinki#73 (comment)
danipran
force-pushed
the
convert-amr-to-list
branch
from
c735af7 to
6574c54
Compare
akikoskinen
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #73
This converts
amrto a list if it's a string.Apparently, Tunnistamo sends
amras a string, not a list. This screws things up ifdrf-oidc-auth's version is >=1.0.0. However,drf-oidc-auth>=1.0.0 is required for Django 4, so something needs to be done. I went with @nikomakela's suggestion.I suppose it's not a perfect solution, but it should do the job for the time being.