-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nsv victory final stages #6796
Merged
TheLordME
merged 54 commits into
Citadel-Station-13:master
from
GySgtMurphy:NSV-Victory-Final-Stages
Oct 15, 2024
Merged
Nsv victory final stages #6796
TheLordME
merged 54 commits into
Citadel-Station-13:master
from
GySgtMurphy:NSV-Victory-Final-Stages
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
binoculars and hand labeler the most powerful weapon in the game
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
oh god oh no the area code is so spaghetti at this point help me someone please
point defense systems are explorer/pilot/sar now start with binocs in the locker sar now starts with a medical flaregun and illum shells in the locker
…rphy/Citadel-Station-13-RP into NSV-Victory-Final-Stages
github-actions
bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Oct 15, 2024
please update the changelog |
Cl updated |
TheLordME
approved these changes
Oct 15, 2024
silicons
pushed a commit
that referenced
this pull request
Oct 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Slight amounts of map housekeeping regarding the exploration department. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Things being wrong is bad. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: del: Deleted mapped-in binoculars spawns for exploration, as they are now included in explo-related job lockers via code per #6796 del: Removed a toxin treatment pouch from Atlas Explo Shuttle. add: Gave SAR & Explorers some Hand Labelers on both Atlas and Triumph. tweak: Touched up some of the erroneous or incomplete floor markings in Atlas exploration. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ship is technically functional. Still needs to be fixed up and cleaned up.
Why It's Good For The Game
Changelog
🆑
add: Created 2 "nav" color Defines used by the new map's hallways.
add: Created several Areas related to the new map.
tweak: Too many Victory map edits to list, general development.
tweak: Explorer/Pathfinder/Pilot/SAR closets now start with binoculars.
tweak: SAR closets now start with a paramedic's flare gun and a box of illumination shells.
/:cl: