Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Borg Drink Fab upgrade #6121

Merged

Conversation

TheKnightofAura
Copy link
Contributor

Updates Service Borg to have slightly more ingredients, now that more exotic ones have been added to make bar-tending complicated

About The Pull Request

Gives Grenadine and Cream to the borg drink maker

Why It's Good For The Game

Grenadine and cream are two broadly used ingredients in drinks, far more common then some of the ones already available to borgs. We've had a lot of new niche ingredients added, and there's also still a lot of specialty ingredients that are a pain for our mechanical bartending friends to access if we want that artificial difficulty.

Changelog

🆑
add: Added two existing reagents to borg machine
/:cl:

… exotic ones have been added to make bar-tending complicated
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2023
@TheKnightofAura
Copy link
Contributor Author

TheKnightofAura commented Nov 5, 2023

The other esoteric drink ingredients mentioned fall into two groups:
Ones I'd add if we don't care about limiting:

  • Matcha Powder
  • Taro Powder
  • Cocoa
  • Coconut Milk

And ones that have reasonable thematic reasons for not having access:

  • Honey
  • Capsacian
  • Blood
  • Blud
  • Hrukhza Leaf Extract
  • Ethanol
  • Holy Water
  • Nutriment
  • Enzyme
  • animal protein
  • Welder fuel
  • Nothing

Some of these are more widely used then others, and a few might be able to finagle reasons to be added, but both lists are beyond the scope of what I intend to be an 'inarguable' advancement of the drink-making capabilities of the service borg.

silicons pushed a commit that referenced this pull request Nov 6, 2023
Captain277
Captain277 previously approved these changes Nov 6, 2023
@Captain277
Copy link
Contributor

The other esoteric drink ingredients mentioned fall into two groups: Ones I'd add if we don't care about limiting:

  • Matcha Powder
  • Taro Powder
  • Cocoa
  • Coconut Milk

And ones that have reasonable thematic reasons for not having access:

  • Honey
  • Capsacian
  • Blood
  • Blud
  • Hrukhza Leaf Extract
  • Ethanol
  • Holy Water
  • Nutriment
  • Enzyme
  • animal protein
  • Welder fuel
  • Nothing

Some of these are more widely used then others, and a few might be able to finagle reasons to be added, but both lists are beyond the scope of what I intend to be an 'inarguable' advancement of the drink-making capabilities of the service borg.

As you mention in your post, the first four are fine to add, but I wouldn't add the others. If you want to add those first four to the list before this gets merged, let me know.

@Captain277 Captain277 merged commit a2a051c into Citadel-Station-13:master Nov 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants