Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes radiation wave decay inverse square instead of exponential #6044

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Putnam3145
Copy link
Contributor

About The Pull Request

As title. Right now it decays exponentially instead of through an inverse square law.

Why It's Good For The Game

It... makes radiation stronger, actually. Not sure this is better. But engineers should be wearing rad suits when there's radiation anyway, so, y'know. Probably good.

Changelog

🆑
fix: "Inverse square factor" for radiation now actually inverse square instead of exponential decay
/:cl:

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2023
@silicons
Copy link
Contributor

silicons commented Oct 2, 2023

this is a drastic change that must be locally or live tested

@github-actions
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Oct 17, 2023
@TheLordME TheLordME removed the Stale label Oct 18, 2023
Copy link

github-actions bot commented Nov 2, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Nov 2, 2023
@silicons silicons added Stale Exempt Immune to Stale and removed Stale labels Nov 6, 2023
silicons pushed a commit that referenced this pull request Dec 1, 2023
silicons pushed a commit that referenced this pull request Dec 1, 2023
silicons pushed a commit that referenced this pull request Dec 2, 2023
silicons pushed a commit that referenced this pull request Dec 4, 2023
silicons pushed a commit that referenced this pull request Dec 4, 2023
silicons pushed a commit that referenced this pull request Dec 4, 2023
Copy link
Collaborator

@TheLordME TheLordME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been TMed for a week now

silicons pushed a commit that referenced this pull request Dec 6, 2023
silicons pushed a commit that referenced this pull request Dec 6, 2023
@TheLordME TheLordME merged commit 1737250 into master Dec 7, 2023
@TheLordME TheLordME deleted the fix-radiation branch December 7, 2023 09:12
timothyteakettle added a commit that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Stale Exempt Immune to Stale Testmerge Only this isn't tested yet gdi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants