Makes the power monitor display supply/draw correctly #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/XS
silicons
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adjusts the Javascript to make the power monitoring program display in kW correctly. Additionally, adjusts the default "PEAK_DRAW" to match the change from amounts being displayed in watts to kilowatts, which makes the progress bars actually useful. I hope to also make the number display with our better render_power method, but this is ready to be testmerged and will immediately make the program useful again. Testmerge only until I either figure it out or give up.
Why It's Good For The Game
Whoever coded the Javascript for the interface decided to make it do math directly rather than make the dm file providing the number do it. This caused the power manager's supply/draw numbers to be divided by 1,000 (and any decimals cut off), which made it pretty useless. This fixes it.
Changelog
🆑 SingingSpock
fix: The supply/draw numbers on the monitor will now display correctly.
/:cl: