-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports virgo's Jukebox interface / overhauls the old one, portable music players and more jukebox songs / some fixes (Oh my!) #5996
Merged
silicons
merged 19 commits into
Citadel-Station-13:master
from
pixelkitty286:Music-player
Sep 29, 2023
Merged
Ports virgo's Jukebox interface / overhauls the old one, portable music players and more jukebox songs / some fixes (Oh my!) #5996
silicons
merged 19 commits into
Citadel-Station-13:master
from
pixelkitty286:Music-player
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made media into it's own subsystem Prepped jukeboxes to use Tgui
Holy bingle I can have portable music players!?!? Cat win!
github-actions
bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Sep 18, 2023
This PR is in it's final revision I can not revise this further due to life reasons. |
silicons
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This ports over and makes the jukebox media player into a subsystem wile also overhauling / porting over virgo's tgui interface for jukeboxes.
This PR also brings over the Podzu music player and makes it available to all players in cargo, loadouts, and venders.
It also has a function that is not at the moment working where you can add more music as an admin. But if someone is willing to fix the admin system I can see about making that function work instead of leaving it commented out.
I will in another PR go over more of the broken songs and eliminate or fix them. (I listen to music heavily when playing here)
Why It's Good For The Game
The current Jukebox GUI is horrible and the current media player system is not modular what so ever and is clunky to use, but the port of virgo's jukebox UI is not really perfect, however it is leagues better than Nano. (PLEASE I SUFFERED TO PORT IT)
Portable music players are really nice and sharing tunes with fellow players is sweet.
Changelog
🆑
add: Portable music players!, and improved Jukebox UI
tweak: jukebox.json
qol: Jukebox ui is not as clunky
fix: Jukebox ui
soundadd: Jukebox music?
code: media players, jukebox ui, and portable music player ui
refactor: refactored media players (they are their own subsystem now!)
config: Added more songs and also configured changes to the jukebox.json to work with the changes
admin: some jukebox code (idk if what I did caused anything)
/:cl: