Skip to content

Commit

Permalink
Explorer Radio format changes/fixes & Entertainment Radio format fixes (
Browse files Browse the repository at this point in the history
#5994)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

- Fixes Explorer and Entertainment radio formatting. They lacked the
CSS. Now they have it.
- Explorer radio is given a different color besides bland grey. They get
something more pink instead. Maybe fitting, considering their close
relations to the Research department.

## Why It's Good For The Game

Grey doesn't quite stand out for communication when you're being
Central's finest murderhobos.

Otherwise, fixes good.

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl:
fix: Explorer radio and entertainment radio formatting has been fixed.
tweak: Explorer radio's colors have been changed.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
BlueWildrose authored Sep 19, 2023
1 parent 816a22c commit 7358ca9
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 3 deletions.
2 changes: 2 additions & 0 deletions code/__DEFINES/spans.dm
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
#define SPAN_DRONE(str) ("<span class='drone'>[str]</span>")
#define SPAN_ENGRADIO(str) ("<span class='engradio'>[str]</span>")
#define SPAN_EXTREMELYBIG(str) ("<span class='extremelybig'>[str]</span>")
#define SPAN_EXPRADIO(str) ("<span class='expradio'>[str]</span>")
#define SPAN_ENTRADIO(str) ("<span class='entradio'>[str]</span>")
#define SPAN_GANGRADIO(str) ("<span class='gangradio'>[str]</span>")
#define SPAN_GHOSTALERT(str) ("<span class='ghostalert'>[str]</span>")
#define SPAN_GREEN(str) ("<span class='green'>[str]</span>")
Expand Down
2 changes: 1 addition & 1 deletion interface/stylesheet.dm
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ em {font-style: normal;font-weight: bold;}
.sciradio {color: #993399;}
.suppradio {color: #5F4519;}
.servradio {color: #6eaa2c;}
.expradio {color: #555555;}
.expradio {color: #c240a1;}

.redteamradio {color: #ff0000;}
.blueteamradio {color: #0000ff;}
Expand Down
2 changes: 1 addition & 1 deletion tgui/packages/tgui-panel/chat/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const MESSAGE_TYPES = [
type: MESSAGE_TYPE_RADIO,
name: 'Radio',
description: 'All departments of radio messages',
selector: '.alert, .minorannounce, .syndradio, .aiprivradio, .entradio, .centcomradio, .aiprivradio, .comradio, .secradio, .gangradio, .engradio, .medradio, .sciradio, .suppradio, .servradio, .radio, .deptradio, .binarysay, .newscaster, .resonate',
selector: '.alert, .minorannounce, .syndradio, .aiprivradio, .entradio, .centcomradio, .aiprivradio, .comradio, .secradio, .gangradio, .engradio, .expradio, .medradio, .sciradio, .suppradio, .servradio, .radio, .deptradio, .binarysay, .newscaster, .resonate',
},
{
type: MESSAGE_TYPE_INFO,
Expand Down
8 changes: 8 additions & 0 deletions tgui/packages/tgui-panel/styles/goon/chat-dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,14 @@ em {
color: #6ca729;
}

.expradio {
color: #c471af;
}

.entradio {
color: #52b985;
}

.syndradio {
color: #8f4a4b;
}
Expand Down
6 changes: 5 additions & 1 deletion tgui/packages/tgui-panel/styles/goon/chat-light.scss
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,11 @@ em {
}

.expradio {
color: #555555;
color: #c240a1;
}

.entradio {
color: #339966;
}

.syndradio {
Expand Down

0 comments on commit 7358ca9

Please sign in to comment.