Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iosxe show ip ospf interface brief regex to parse area correctly #879

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dpskvn
Copy link

@dpskvn dpskvn commented Aug 20, 2024

Description

The iosxe parser for show ip ospf interface brief was capturing the area as a numerical value. I've updated it to capture a string.

Motivation and Context

When using the iosxe parser for show ip ospf interface brief, as the parser was looking for numerical values only, it would skip entries where the OSPF area was written in dot notation (i.e. 0.0.0.0).

This change brings it in line with the show ip ospf interface parser which correctly captures the area as a string.

Impact (If any)

There is no negative impact as the returned value (even for numerical-only area captures) is converted to dot notation in the generated output.

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

Edit: Added tests for the change to the PR

@dpskvn dpskvn requested a review from a team as a code owner August 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant