Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for isis learn and removed duplicate parser #791

Merged
merged 7 commits into from
Oct 12, 2023

Conversation

Taarini
Copy link
Contributor

@Taarini Taarini commented Oct 10, 2023

Description

Traceback (most recent call last):
  File "/usr/lib/python3.8/code.py", line 90, in runcode
    exec(code, self.locals)
  File "<console>", line 1, in <module>
  File "src/genie/conf/base/device.py", line 632, in genie.conf.base.device.Device.learn
  File "/home/jenkins/.local/lib/python3.8/site-packages/genie/libs/ops/isis/iosxe/isis.py", line 447, in learn
    self.make()
  File "/home/jenkins/.local/lib/python3.8/site-packages/genie/ops/base/base.py", line 103, in make
    self.maker.make(*args, **kwargs)
  File "src/genie/ops/base/maker.py", line 315, in genie.ops.base.maker.Maker.make
  File "src/genie/ops/base/maker.py", line 427, in genie.ops.base.maker.Maker._call_parser
  File "src/genie/metaparser/_metaparser.py", line 308, in genie.metaparser._metaparser.MetaParser.parse
  File "/home/jenkins/.local/lib/python3.8/site-packages/genie/libs/parser/iosxe/show_clns.py", line 669, in cli
    type_dict.update({'area_address': group['area_address'].split()})
UnboundLocalError: local variable 'type_dict' referenced before assignment

Motivation and Context

To fix the above issue and also remove the duplicate parser

Impact (If any)

Not backward compatible

Screenshots:

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

@Taarini Taarini requested a review from a team as a code owner October 10, 2023 20:21
Copy link
Contributor

@GerriorL GerriorL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog and make JSON

@GerriorL GerriorL self-requested a review October 10, 2023 21:08
@Taarini Taarini merged commit b901c3f into master Oct 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants