Skip to content

Commit

Permalink
Fix value range of ttl attribute
Browse files Browse the repository at this point in the history
  • Loading branch information
danischm committed Sep 3, 2024
1 parent a077f8f commit 892ebcc
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.6 (unreleased)

- Fix value range of `ebgp_multihop_ttl` attribute of `nxos_bgp_peer` resource

## 0.5.5

- Fix importing of resources
Expand Down
4 changes: 4 additions & 0 deletions docs/guides/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ description: |-

# Changelog

## 0.5.6 (unreleased)

- Fix value range of `ebgp_multihop_ttl` attribute of `nxos_bgp_peer` resource

## 0.5.5

- Fix importing of resources
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/bgp_peer.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ resource "nxos_bgp_peer" "example" {
- `description` (String) Peer description.
- `device` (String) A device name from the provider configuration.
- `ebgp_multihop_ttl` (Number) eBGP Multihop TTL
- Range: `2`-`255`
- Range: `0`-`255`
- `hold_time` (Number) BGP Hold Timer in seconds. The value must be greater than the keepalive timer
- Range: `3`-`3600`
- Default value: `180`
Expand Down
2 changes: 1 addition & 1 deletion gen/definitions/bgp_peer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ attributes:
type: Int64
description: "eBGP Multihop TTL"
example: 5
min_int: 2
min_int: 0
max_int: 255
omit_empty_value: true
- nxos_name: ctrl
Expand Down
4 changes: 2 additions & 2 deletions internal/provider/resource_nxos_bgp_peer.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions templates/guides/changelog.md.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ description: |-

# Changelog

## 0.5.6 (unreleased)

- Fix value range of `ebgp_multihop_ttl` attribute of `nxos_bgp_peer` resource

## 0.5.5

- Fix importing of resources
Expand Down

1 comment on commit 892ebcc

@pritispa
Copy link

@pritispa pritispa commented on 892ebcc Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 and 1 are actually not valid values for ebgp multihop ttl

Please sign in to comment.