fix(LH-74651): terraform-provider-cdo-ci (#125)

* fix * trigger acceptance tests * fix+1 * fix cdfmc name * run again with debug log * retrigger to see if reonboard ftd fix tests * undo running acceptance tests in pr
CiscoDevNet · Jan 22, 2024 · 6b98bd7 · 6b98bd7
1 parent 007cfae
commit 6b98bd7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/provider/.github-action.env b/provider/.github-action.env
@@ -53,7 +53,7 @@ ASA_DATA_SOURCE_TAGS=ci
 CONNECTOR_DATA_SOURCE_NAME=CDO_terraform-provider-cdo-SDC-1
 CONNECTOR_RESOURCE_NAME=test-sdc-1
 CONNECTOR_RESOURCE_NEW_NAME=test-sdc-2
-CLOUD_FMC_DATA_SOURCE_HOSTNAME=terraform-provider-cdo.app.staging.cdo.cisco.com
-CLOUD_FMC_DATA_SOURCE_SOFTWARE_VERSION=7.3.1-build 6035
+CLOUD_FMC_DATA_SOURCE_HOSTNAME=cdo-terraform-provider-cdo.app.staging.cdo.cisco.com
 CLOUD_FMC_RESOURCE_NAME=FMC
-CLOUD_FMC_RESOURCE_HOSTNAME=terraform-provider-cdo.app.staging.cdo.cisco.com
+CLOUD_FMC_RESOURCE_HOSTNAME=cdo-terraform-provider-cdo.app.staging.cdo.cisco.com
+TF_LOG=DEBUG
diff --git a/provider/internal/acctest/environment.go b/provider/internal/acctest/environment.go
@@ -299,10 +299,6 @@ func (e *env) CloudFmcDataSourceHostname() string {
 	return e.mustGetString("CLOUD_FMC_DATA_SOURCE_HOSTNAME")
 }
 
-func (e *env) CloudFmcDataSourceSoftwareVersion() string {
-	return e.mustGetString("CLOUD_FMC_DATA_SOURCE_SOFTWARE_VERSION")
-}
-
 func (e *env) CloudFmcResourceName() string {
 	return e.mustGetString("CLOUD_FMC_RESOURCE_NAME")
 }

diff --git a/provider/internal/cdfmc/data_source_test.go b/provider/internal/cdfmc/data_source_test.go
@@ -8,11 +8,9 @@ import (
 )
 
 var testCdFmc = struct {
-	Hostname        string
-	SoftwareVersion string
+	Hostname string
 }{
-	Hostname:        acctest.Env.CloudFmcDataSourceHostname(),
-	SoftwareVersion: acctest.Env.CloudFmcDataSourceSoftwareVersion(),
+	Hostname: acctest.Env.CloudFmcDataSourceHostname(),
 }
 
 const testCdFmcTemplate = `
@@ -30,7 +28,6 @@ func TestAccCdFmcDataSource(t *testing.T) {
 				Config: acctest.ProviderConfig() + testCdfmcConfig,
 				Check: resource.ComposeAggregateTestCheckFunc(
 					resource.TestCheckResourceAttr("data.cdo_cdfmc.test", "hostname", testCdFmc.Hostname),
-					resource.TestCheckResourceAttr("data.cdo_cdfmc.test", "software_version", testCdFmc.SoftwareVersion),
 				),
 			},
 		},