FTD Onboarding Verification Tests (#46)

Co-authored-by: Siddhu Warrier <[email protected]>

client/device/cloudfmc/fmcconfig/retry.go

@@ -37,6 +37,9 @@ func UntilTaskStatusSuccess(ctx context.Context, client http.Client, readInp Rea
 func UntilCreateDeviceRecordSuccess(ctx context.Context, client http.Client, createDeviceRecordInput CreateDeviceRecordInput, output *CreateDeviceRecordOutput) retry.Func {
 	return func() (bool, error) {
 		createDeviceOutp, err := CreateDeviceRecord(ctx, client, createDeviceRecordInput)
+		if err != nil {
+			return false, err
+		}
 		*output = *createDeviceOutp
 		if err != nil {
 			return false, err

client/device/cloudftd/cloudftdonboarding/create.go

@@ -9,6 +9,7 @@ import (
 	"github.com/CiscoDevnet/terraform-provider-cdo/go-client/device/cloudftd"
 	"github.com/CiscoDevnet/terraform-provider-cdo/go-client/internal/http"
 	"github.com/CiscoDevnet/terraform-provider-cdo/go-client/internal/retry"
+	"github.com/CiscoDevnet/terraform-provider-cdo/go-client/model/ftd/license"
 	"github.com/CiscoDevnet/terraform-provider-cdo/go-client/user"
 	"time"
 )
@@ -71,13 +72,18 @@ func Create(ctx context.Context, client http.Client, createInp CreateInput) (*Cr
 	if err != nil {
 		return nil, err
 	}
+	// 3.1.5 handle license
+	licenseCaps, err := license.DeserializeAllFromCdo(readFtdOutp.Metadata.LicenseCaps)
+	if err != nil {
+		return nil, err
+	}
 	// 3.2 create ftd device
 	createDeviceInp := fmcconfig.NewCreateDeviceRecordInputBuilder().
 		Type("Device").
 		NatId(readFtdOutp.Metadata.NatID).
 		Name(readFtdOutp.Name).
 		AccessPolicyUid(readFtdOutp.Metadata.AccessPolicyUid).
-		LicenseCaps(readFtdOutp.Metadata.LicenseCaps).
+		LicenseCaps(&licenseCaps).
 		PerformanceTier(readFtdOutp.Metadata.PerformanceTier).
 		RegKey(readFtdOutp.Metadata.RegKey).
 		FmcDomainUid(fmcDomainUid).
@@ -117,6 +123,26 @@ func Create(ctx context.Context, client http.Client, createInp CreateInput) (*Cr
 	if err != nil {
 		return nil, err
 	}
+	// 4.3 wait until state machine done
+	err = retry.Do(
+		cloudftd.UntilSpecificStateDone(
+			ctx,
+			client,
+			cloudftd.NewReadSpecificInputBuilder().
+				Uid(ftdSpecificOutp.SpecificUid).
+				Build(),
+		),
+		retry.NewOptionsBuilder().
+			Retries(-1).
+			Delay(1*time.Second).
+			Timeout(20*time.Minute). // usually done in less than 5 minutes because we already registered in FTDc
+			Logger(client.Logger).
+			EarlyExitOnError(false).
+			Build(),
+	)
+	if err != nil {
+		return nil, err
+	}
 
 	return &createOutp, nil
 }