Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_changes] Adding missing parameters to function_node resource/datasource. #1144

Merged
merged 10 commits into from
Mar 25, 2024
Merged

[minor_changes] Adding missing parameters to function_node resource/datasource. #1144

merged 10 commits into from
Mar 25, 2024

Conversation

anvitha-jain
Copy link
Collaborator

@anvitha-jain anvitha-jain commented Jan 23, 2024 •
edited
Loading

  1. Adding ip parameter to fix resource creation when is_static_ip parameter is set in aci_cloud_l4_l7_native_load_balancer resource/datasource.

fixes #1130 #1129

@anvitha-jain anvitha-jain linked an issue Jan 23, 2024 that may be closed by this pull request
Ability to set static ip under aci_cloud_l4_l7_native_load_balancer resource #1129
Closed
@anvitha-jain anvitha-jain self-assigned this Feb 27, 2024
@anvitha-jain anvitha-jain linked an issue Feb 27, 2024 that may be closed by this pull request
Add an attribute to configure "Additional Frontend IPs" for the Azure Network Load Balancer - L4-L7 device (DCNE-89) #1133
Open
@anvitha-jain anvitha-jain changed the title [minor_changes] Adding missing parameters [minor_changes] Adding missing parameters to function_node resource/datasource. Mar 1, 2024
@anvitha-jain anvitha-jain force-pushed the l4l7sg_function_node branch from 8fd3f5f to fa46bc2 Compare March 2, 2024 00:42
@anvitha-jain anvitha-jain requested review from sajagana, lhercot, akinross, samiib, gmicol and shrsr and removed request for sajagana and lhercot March 2, 2024 00:42
akinross
akinross requested changes Mar 2, 2024
View reviewed changes
docs/resources/connection.md Outdated Show resolved Hide resolved
aci/data_source_aci_cloudlb.go Outdated Show resolved Hide resolved
aci/data_source_aci_cloudlb.go Outdated Show resolved Hide resolved
aci/resource_aci_cloudlb.go Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain force-pushed the l4l7sg_function_node branch from b397141 to e94576c Compare March 4, 2024 18:47
@anvitha-jain anvitha-jain requested a review from akinross March 4, 2024 18:47
samiib
samiib requested changes Mar 5, 2024
View reviewed changes
internal/provider/annotation_unsupported.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain requested a review from samiib March 5, 2024 18:26
akinross
akinross requested changes Mar 6, 2024
View reviewed changes
internal/provider/provider.go Outdated Show resolved Hide resolved
docs/data-sources/cloud_l4_l7_native_load_balancer.md Outdated Show resolved Hide resolved
@anvitha-jain
[minor_changes] Adding ip parameter to fix resource creation when is_…
d8ebdd8 
…static_ip parameter is set in aci_cloud_l4_l7_native_load_balancer resource/datasource.
@anvitha-jain
[minor_changes] Added connector_type and att_notify parameters to 'ac…
fd9dab8 
…i_function_mode' and fixed documentation for aci_function_node and and aci_connection to have a particular format for names and added examples to show these changes.
@anvitha-jain
[ignore] Adding vendor files.
533498f
@anvitha-jain
[ignore] Fixed documentation for cloud_l4_l7_native_load_balancer by …
967ceb4 
…adding static_ip_address and added Type to the missing aruments in aci_connection docs.
@anvitha-jain
[ignore] Added annotation_unsupported.go file back and fixed go.mod a…
7092a18 
…nd go.sum.
@anvitha-jain anvitha-jain force-pushed the l4l7sg_function_node branch from be90d78 to 7092a18 Compare March 6, 2024 19:35
@anvitha-jain anvitha-jain requested a review from akinross March 6, 2024 19:43
samiib
samiib previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

akinross
akinross previously approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Mar 11, 2024
View reviewed changes
@anvitha-jain anvitha-jain dismissed stale reviews from gmicol, shrsr, akinross, and samiib via 7af55ba March 11, 2024 17:59
gmicol
gmicol previously approved these changes Mar 12, 2024
View reviewed changes
lhercot
lhercot requested changes Mar 12, 2024
View reviewed changes
docs/resources/connection.md Outdated Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
examples/function_node/main.tf Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
legacy-docs/docs/r/connection.html.markdown Outdated Show resolved Hide resolved
legacy-docs/docs/r/function_node.html.markdown Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain requested a review from lhercot March 12, 2024 19:53
lhercot
lhercot requested changes Mar 14, 2024
View reviewed changes
docs/resources/function_node.md Outdated Show resolved Hide resolved
examples/function_node/main.tf Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
examples/function_node/main.tf Outdated Show resolved Hide resolved
examples/function_node/main.tf Show resolved Hide resolved
legacy-docs/docs/r/function_node.html.markdown Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain removed a link to an issue Mar 20, 2024
Add an attribute to configure "Additional Frontend IPs" for the Azure Network Load Balancer - L4-L7 device (DCNE-89) #1133
Open
shrsr
shrsr requested changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see above comment

@anvitha-jain anvitha-jain requested a review from shrsr March 22, 2024 17:45
shrsr
shrsr approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit ae49748 into CiscoDevNet:master Mar 25, 2024
@anvitha-jain anvitha-jain deleted the l4l7sg_function_node branch July 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

Assignees

@anvitha-jain anvitha-jain

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@anvitha-jain @lhercot @shrsr @akinross @samiib @gmicol