Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue97 jeremypng #100

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Issue97 jeremypng #100

wants to merge 9 commits into from
+40 −27

Conversation

jeremypng
Copy link

Let me know if you guys want anything else changed here. This code works in my testing.

update: fixed spacing, hopefully passes CI this time

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
46.3% 46.3% Duplication

@jasonking3
Copy link
Collaborator

@jeremypng - I think we could pass the SonarCloud check if we just called get_action_status from waitfor_action_completion rather than duplicating all that code. Other than that, I think we are good. I like the change to also look at property names.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeremypng
Copy link
Author

Ok, I brought this one up to date w/ master, and removed the duplicated code in waitfor_action_completion. Are we good to go?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 8 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremypng @jasonking3