This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbasan
reviewed
Mar 21, 2024
jpkrajewski
force-pushed
the
dev/service-parcels
branch
from
March 27, 2024 11:56
e828e6f
to
0b6d158
Compare
…te_parcel_from_template function. Convert the create_parcel methods to instance methods, allowing them to access class attributes and methods. Split large create_parcel functions
… feature profile integration test structure. Add more Castable literals to the normalizer. Change name factory method to parcel_factory. Change VPN model type to lan/vpn.
…moedl creation. Remove static UUID in tests, instead create dynamicly. Add IPv6Interface and IPv4Interface cast in normalizer. Change models to use casted Global[Interface] values. Fix Svi model
… for sdwan demo data.
…prove logging during pushing ux2 config. Minor fixes for service models. Refactor config pusher. Add pushing service FP and parcels. Working for internal vmanage
jpkrajewski
force-pushed
the
dev/service-parcels
branch
from
April 2, 2024 09:03
778aeac
to
19b9007
Compare
… for creation. Add default values for ospf model (helps whe default template is empty and endpoint needs values). Comment logic for interface assigement since there can be many vpns and interfaces in one feature profile correct implementation is needed
* update deprecated github actions * fix type error
moved to: cisco-open/cisco-catalyst-wan-sdk#2 |
21 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
create_parcel
methods to instance methods, allowing them to access class attributes and methods. Split largecreate_parcel
functionsCantConvertException
class to handle cases where the UX1 data is insufficient to instantiate a UX2 parcel.FeatureProfileBuilder
class. It let's you build feature profile and add parcels with ease.Description of changes:
Checklist: