This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t class. Create factory for parcel pushing strategy. Create factory for api classes
jpkrajewski
requested review from
kagrski,
JimOverholt,
igosoft,
sbasan and
bboot2
as code owners
March 17, 2024 22:42
ghost
requested a review
from brdw87
March 18, 2024 08:45
sbasan
reviewed
Mar 18, 2024
parcel_map: Dict[UUID, TransformedParcel] | ||
|
||
|
||
class UX2ConfigRollback: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a dataclass ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to Dataclass
sbasan
reviewed
Mar 18, 2024
|
||
config_pusher = UX2ConfigPusher(session, config) | ||
rollback = config_pusher.push() | ||
# for config_group in config.config_groups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this commented code already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed commented code.
… API so it needs to be serializable
sbasan
approved these changes
Mar 18, 2024
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
Video - Device Templates (ux1) migrated to Configuration Groups (ux2)
Recording.mp4
Test-script:
Checklist: