Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use AnyPolicyDefinitionInfo / AnyPolicyListInfo in UX1Config #523

Merged
merged 36 commits into from
Mar 14, 2024
Merged

Use AnyPolicyDefinitionInfo / AnyPolicyListInfo in UX1Config #523

merged 36 commits into from
Mar 14, 2024

Conversation

sbasan
Copy link
Collaborator

@sbasan sbasan commented Mar 14, 2024

Pull Request summary:

  1. Remove policy related models from endpoints directory - was causing circular import problem when trying to define an union.
  2. Use separate file for each policy list model
  3. Use AnyPolicyDefinitionInfo / AnyPolicyListInfo in UX1Config (which are containing both item id and definition - needed for migration steps)

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

sbasan added 30 commits March 13, 2024 23:11
@sbasan
phase 1
61bf5c0
@sbasan
separate endpoint from models, add app_probe list
eb50414
@sbasan
separate app-list
19d3d9c
@sbasan
separate as-path-list
c0225c0
@sbasan
separate class-map-list
9b08773
@sbasan
separate community-list, expanded-community-list
2a303b1
@sbasan
separate data-ipv6-prefix-list
79ab87c
@sbasan
separate data-prefix-list
f8d1a98
@sbasan
separate fqdn-list
9c913e7
@sbasan
separate geo-location-list
2198dbd
@sbasan
separate ips-signature-list
22e9bc0
@sbasan
separate ipv6-prefix-list
404a299
@sbasan
separate local-app-list
3b410a7
@sbasan
separate local-domain-list
19182ad
@sbasan
separate mirror-list
6454e72
@sbasan
separate policer-list
9cb7eb7
@sbasan
separate port-list
9c55b00
@sbasan
separate preferred-color-group-list
cd96609
@sbasan
separate prefix-list
f8cde35
@sbasan
separate protocol-name-list
0c33c40
@sbasan
separate region-list
2e7b8eb
@sbasan
separate site-list
02d7bfe
@sbasan
separate sla-class-list
6645d8e
@sbasan
separate tloc-list
4902258
@sbasan
separate url-lists
d427dff
@sbasan
separate vpn-list
0579c35
@sbasan
separate zone-list
0db6ed9
@sbasan
move PolicyListBase
f4846ea
@sbasan
add copyright
476f4c5
@sbasan
separate policy definition models from endpoints
1f5db57
@sbasan sbasan requested a review from a user March 14, 2024 09:45
ghost
ghost approved these changes Mar 14, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbasan sbasan merged commit 7dbffb2 into dev-uxmt Mar 14, 2024
10 checks passed
@sbasan sbasan deleted the tmp/rearrange-policy-models branch March 14, 2024 11:21
@JimOverholt JimOverholt mentioned this pull request Apr 25, 2024
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kagrski kagrski Awaiting requested review from kagrski kagrski is a code owner

@JimOverholt JimOverholt Awaiting requested review from JimOverholt JimOverholt is a code owner

@igosoft igosoft Awaiting requested review from igosoft igosoft is a code owner

@bboot2 bboot2 Awaiting requested review from bboot2 bboot2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbasan