Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Changed the way of waiting for task completion. #509

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

brdw87
Copy link
Collaborator

@brdw87 brdw87 commented Mar 6, 2024

Pull Request summary:

Change the way of waiting for task completion. Now Task().wait_for_complete() waits for the end of task, not as in the previous implementation for the first fail

Description of changes:

The previous implementation stops pooling task object when at least one subtask has failed. It caused problems with further processing the next tasks, some of them depend on the still running task.

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@brdw87 brdw87 requested a review from a user March 6, 2024 14:39
@sbasan sbasan merged commit 0c7db1e into main Mar 6, 2024
12 checks passed
@sbasan sbasan deleted the wait_for_complete_fix branch March 6, 2024 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants