Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Upgrades with Remote Server #497

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Upgrades with Remote Server #497

merged 6 commits into from
Mar 5, 2024

Conversation

cicharka
Copy link
Collaborator

@cicharka cicharka commented Feb 27, 2024 •
edited
Loading

Pull Request summary:

Rework of software operations for upgrades with Remote Server.

Description of changes:

  • rework install method to include remote server files
  • remove usage of old Device (coming from attrs) - instead use DeviceDetailsResponse
  • enhance upgrades_helper.py to include c8000V upgrades

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@cicharka
Copy link
Collaborator Author

Still WIP because adding unittests

@cicharka cicharka marked this pull request as ready for review February 28, 2024 12:21
sbasan
sbasan approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@sbasan sbasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbasan sbasan merged commit 526bda1 into main Mar 5, 2024
12 checks passed
@sbasan sbasan deleted the fr/remote_server_upgrades branch March 5, 2024 09:45
@JimOverholt JimOverholt mentioned this pull request Apr 25, 2024
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbasan sbasan sbasan approved these changes

@kagrski kagrski Awaiting requested review from kagrski kagrski is a code owner

@JimOverholt JimOverholt Awaiting requested review from JimOverholt JimOverholt is a code owner

@igosoft igosoft Awaiting requested review from igosoft igosoft is a code owner

@bboot2 bboot2 Awaiting requested review from bboot2 bboot2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicharka @sbasan