Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove casting validators #493

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Remove casting validators #493

merged 3 commits into from
Feb 26, 2024

Conversation

PrzeG
Copy link
Collaborator

@PrzeG PrzeG commented Feb 26, 2024

Pull Request summary:

Remove validators casting bool/IP to string. Add BoolStr type, that functions as a bool, but serializes to string in json payload.

Description of changes:

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

pyproject.toml Outdated Show resolved Hide resolved
@PrzeG PrzeG force-pushed the remove_casting_validators branch from 9f86124 to cc47fef Compare February 26, 2024 12:29
Copy link
Collaborator

@sbasan sbasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PrzeG PrzeG merged commit 3ad0e51 into main Feb 26, 2024
12 checks passed
@PrzeG PrzeG deleted the remove_casting_validators branch February 26, 2024 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants