Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix config_migration #490

Merged
merged 2 commits into from
Feb 23, 2024
Merged

fix config_migration #490

merged 2 commits into from
Feb 23, 2024

Conversation

sbasan
Copy link
Collaborator

@sbasan sbasan commented Feb 23, 2024

Pull Request summary:

  • remove nested annotated unions in AnyParcel (workaround, looks like FastAPI generates shema in a way that it generates errors)
  • fix criteria validator so transform passes

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

jpkrajewski
jpkrajewski approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@jpkrajewski jpkrajewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbasan sbasan merged commit e79a479 into dev-ux-migration Feb 23, 2024
10 checks passed
@sbasan sbasan deleted the fix/fastapi-ux-config-schema branch February 23, 2024 14:44
jpkrajewski pushed a commit that referenced this pull request Mar 7, 2024
@sbasan @jpkrajewski
fix config_migration (#490)
ad3aeb3 
* fix ux-2 schema breaking models, fix transform

* remove URL(Allow/Block)Parcel from overloaded methods
@JimOverholt JimOverholt mentioned this pull request Apr 25, 2024
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpkrajewski jpkrajewski jpkrajewski approved these changes

@kagrski kagrski Awaiting requested review from kagrski kagrski is a code owner

@JimOverholt JimOverholt Awaiting requested review from JimOverholt JimOverholt is a code owner

@igosoft igosoft Awaiting requested review from igosoft igosoft is a code owner

@bboot2 bboot2 Awaiting requested review from bboot2 bboot2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbasan @jpkrajewski