This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use Literals instead (str, Enum) in models #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
Use
Literal
over theEnums
. Justification:(str, Enum)
can be problematic as__str__
!=__format__
for EnumLiteral
no explicit import of specificEnum
is neededSupport Literal when using
as_default
andas_global
(additional optional argument must be provided).additional minor refactoring:
serialization_alias
andvalidation_alias
when applicableRefId
withGlobal[UUID]
catalystwan/models/configuration/feature_profile/sdwan/policy_object/__init__.py
andcatalystwan/models/policy/__init__.py
using PEP-562 featuresDescription of changes:
[Add more in depth analysis of what changed, provide logs, examples of usage]
Checklist: