This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Remove CiscoVPN and CiscoVPNInterface jinja files #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagrski
requested review from
JimOverholt,
igosoft,
sbasan and
bboot2
as code owners
September 19, 2023 13:49
dariuszniedzielski-codilime
previously approved these changes
Sep 19, 2023
sbasan
previously approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sbasan
force-pushed
the
fr_template/rm/cisco_vpn
branch
from
September 19, 2023 14:36
488c47e
to
73d7aba
Compare
lapson97
previously approved these changes
Sep 20, 2023
…vNet/vManage-client into fr_template/rm/cisco_vpn
dariuszniedzielski-codilime
approved these changes
Sep 25, 2023
sbasan
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
Replace jinja files with dynamic payload generators
vManage-client/vmngclient/api/templates/models/cisco_vpn_interface_model.py
and
vManage-client/vmngclient/api/templates/models/cisco_vpn_model.py
This PR forces user to change scripts where deprecated models were used.