Change Global model bool field to str

CiscoDevNet · Mar 6, 2024 · a6d405b · a6d405b
1 parent 0161490
commit a6d405b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/catalystwan/models/configuration/feature_profile/sdwan/system/global_parcel.py b/catalystwan/models/configuration/feature_profile/sdwan/system/global_parcel.py
@@ -57,7 +57,7 @@ class ServicesIp(BaseModel):
         serialization_alias="servicesGlobalServicesIpLldp",
         validation_alias="servicesGlobalServicesIpLldp",
     )
-    source_intrf: Union[Variable, Global[bool], Default[None]] = Field(
+    source_intrf: Union[Variable, Global[str], Default[None]] = Field(
         default=Default[None](value=None),
         serialization_alias="servicesGlobalServicesIpSourceIntrf",
         validation_alias="servicesGlobalServicesIpSourceIntrf",

diff --git a/catalystwan/utils/config_migration/converters/feature_template/global_.py b/catalystwan/utils/config_migration/converters/feature_template/global_.py
@@ -1,6 +1,3 @@
-from copy import deepcopy
-
-from catalystwan.api.configuration_groups.parcel import as_variable
 from catalystwan.models.configuration.feature_profile.sdwan.system import GlobalParcel
 
 
@@ -15,13 +12,9 @@ def create_parcel(name: str, description: str, template_values: dict) -> GlobalP
         Returns:
             GlobalParcel: A GlobalParcel object with the provided template values.
         """
-        values = deepcopy(template_values)
-        if source_intrf := values.get("source_intrf"):
-            values["source_intrf"] = as_variable(source_intrf.value)
-
         parcel_values = {
             "parcel_name": name,
             "parcel_description": description,
-            "services_global": {"services_ip": {key: value for key, value in values.items()}},
+            "services_global": {"services_ip": {key: value for key, value in template_values.items()}},
         }
         return GlobalParcel(**parcel_values)  # type: ignore