Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmicol
added
enhancement
gmicol
force-pushed
the
mso_port_channel_interface
branch
from
6a28890 to
5016d36
Compare
|
To all reviewers, the test is not complete yet as I am waiting for the ndo_interface_setting module to be merged. Please review accordingly. thanks! |
gmicol
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
samiib
akinross
requested changes
Oct 8, 2024
gmicol
force-pushed
the
mso_port_channel_interface
branch
from
8a0ef1a to
7f88d0a
Compare
akinross
requested changes
Oct 14, 2024
tests/integration/targets/ndo_port_channel_interface/tasks/main.yml
Outdated
Show resolved
Hide resolved
anvitha-jain
requested changes
Oct 18, 2024
tests/integration/targets/ndo_port_channel_interface/tasks/main.yml
Outdated
Show resolved
Hide resolved
anvitha-jain
requested changes
Oct 18, 2024
shrsr
requested changes
Oct 18, 2024
gmicol
force-pushed
the
mso_port_channel_interface
branch
from
0af57d3 to
d5a18f8
Compare
gmicol
force-pushed
the
mso_port_channel_interface
branch
2 times, most recently
from
027e458 to
eb8cf29
Compare
samiib
requested changes
Oct 23, 2024
gmicol
force-pushed
the
mso_port_channel_interface
branch
from
eb8cf29 to
108465f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
===========================================
- Coverage 72.58% 17.75% -54.83%
===========================================
Files 55 93 +38
Lines 5504 8826 +3322
Branches 1462 2329 +867
===========================================
- Hits 3995 1567 -2428
- Misses 1174 7258 +6084
+ Partials 335 1 -334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmicol
force-pushed
the
mso_port_channel_interface
branch
from
4316408 to
c5fd99a
Compare
…nel_interface module. Modify Documentation, Example sections and code logic for interface_descriptions attribute.
gmicol
force-pushed
the
mso_port_channel_interface
branch
from
c5fd99a to
263ef9a
Compare
gmicol
force-pushed
the
mso_port_channel_interface
branch
2 times, most recently
from
b2d05b4 to
9f40b3b
Compare
…dule when handling null value.
gmicol
dismissed stale reviews from anvitha-jain, akinross, samiib, shrsr, and sajagana
via
af83ff4
gmicol
force-pushed
the
mso_port_channel_interface
branch
from
9f40b3b to
af83ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #466
New Modules Added: