Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_changes] Added new module for syncE interface policy (DCNE-192) #521

Merged
merged 5 commits into from
Aug 31, 2024
Merged

[minor_changes] Added new module for syncE interface policy (DCNE-192) #521

merged 5 commits into from
Aug 31, 2024

Conversation

anvitha-jain
Copy link
Collaborator

@anvitha-jain anvitha-jain commented Aug 20, 2024 •
edited by samiib
Loading

(syncEthIntfPolicies object)
part of issue #456
DCNE-129

@anvitha-jain anvitha-jain self-assigned this Aug 20, 2024
@anvitha-jain anvitha-jain added jira-sync Sync this issue to Jira enhancement New feature or request labels Aug 20, 2024
shrsr
shrsr requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failed due to incorrect formatting. Can you please check?

sajagana
sajagana requested changes Aug 22, 2024
View reviewed changes
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
tests/integration/targets/ndo_synce_interface_policy/tasks/main.yml Show resolved Hide resolved
tests/integration/targets/ndo_synce_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/ndo_synce_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Show resolved Hide resolved
@anvitha-jain anvitha-jain requested review from shrsr and sajagana August 23, 2024 23:45
shrsr
shrsr requested changes Aug 27, 2024
View reviewed changes
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
tests/integration/targets/ndo_synce_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_synce_interface_policy.py Show resolved Hide resolved
@anvitha-jain anvitha-jain requested a review from shrsr August 29, 2024 15:31
@anvitha-jain anvitha-jain force-pushed the ndo_fabric_pol_template branch from 88f761b to 74d9e93 Compare August 29, 2024 15:35
shrsr
shrsr requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galaxy importer check failed. Can you resolve?

@anvitha-jain anvitha-jain force-pushed the ndo_fabric_pol_template branch from 74d9e93 to afb8add Compare August 29, 2024 15:41
@anvitha-jain anvitha-jain force-pushed the ndo_fabric_pol_template branch from afb8add to 3d9f3a5 Compare August 29, 2024 15:44
@anvitha-jain anvitha-jain requested a review from shrsr August 29, 2024 15:53
shrsr
shrsr approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 55159d6 into CiscoDevNet:master Aug 31, 2024
12 of 13 checks passed
@anvitha-jain anvitha-jain deleted the ndo_fabric_pol_template branch September 10, 2024 15:34
@lhercot
Copy link
Member

lhercot commented Oct 3, 2024 •
edited
Loading

Closes #441

@github-actions github-actions bot changed the title [minor_changes] Added new module for syncE interface policy [minor_changes] Added new module for syncE interface policy (DCNE-192) Oct 3, 2024
@lhercot lhercot mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@samiib samiib Awaiting requested review from samiib samiib is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

Assignees

@anvitha-jain anvitha-jain

Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anvitha-jain @lhercot @shrsr @akinross @sajagana