Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ndo_l3out_interface_routing_policy to manage L3Out Interface Routing Policy (DCNE-132) #563

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added ndo_l3out_interface_routing_policy to manage L3Out Interface Routing Policy (DCNE-132) #563

wants to merge 9 commits into from
+1,801 −12

Conversation

sajagana
Copy link
Collaborator

@sajagana sajagana commented Nov 8, 2024

No description provided.

@sajagana sajagana linked an issue Nov 8, 2024 that may be closed by this pull request
Enhancement: New module for L3Out Interface Routing Policy in Tenant Tenant Policies Template (DCNE-132) #458
Open
@github-actions github-actions bot changed the title Added ndo_l3out_interface_routing_policy to manage L3Out Interface Routing Policy Added ndo_l3out_interface_routing_policy to manage L3Out Interface Routing Policy (DCNE-132) Nov 8, 2024
@sajagana sajagana force-pushed the 458_l3out_interface_routing_policy branch from 6e1cc12 to 8535b6c Compare November 8, 2024 15:30
samiib
samiib requested changes Nov 12, 2024
View reviewed changes
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Show resolved Hide resolved
@sajagana sajagana requested a review from samiib November 14, 2024 17:07
akinross
akinross requested changes Nov 15, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
@sajagana sajagana mentioned this pull request Nov 15, 2024
Merged
@sajagana sajagana requested a review from akinross November 15, 2024 16:12
@samiib samiib mentioned this pull request Nov 20, 2024
Merged
@sajagana sajagana force-pushed the 458_l3out_interface_routing_policy branch from df95ade to a3d118b Compare December 5, 2024 05:30
@sajagana sajagana requested a review from gmicol December 5, 2024 05:34
gmicol
gmicol previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Dec 10, 2024
View reviewed changes
plugins/module_utils/constants.py Outdated Show resolved Hide resolved
@sajagana sajagana dismissed stale reviews from samiib, shrsr, and gmicol via b7f7bcc December 10, 2024 12:07
akinross
akinross previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana requested review from gmicol and akinross December 13, 2024 07:03
akinross
akinross previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from anvitha-jain, gmicol, samiib, and akinross via 5a46157 December 17, 2024 07:35
akinross
akinross previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr
Copy link
Collaborator

shrsr commented Dec 17, 2024

@sajagana Rebase is required

@sajagana
[minor_change] Added ndo_l3out_interface_routing_policy to manage L3O…
3c637a7 
…ut Interface Routing Policy
@sajagana
[ignore] Updated ndo_l3out_interface_routing_policy module doc and ad…
752e6cd 
…ded new function to handle the update payload creation logic
@sajagana
[ignore] Updated the append_update_ops_data function to support remov…
035a128 
…e operation
@sajagana
[ignore] Updated the append_update_ops_data function logic
78163bb
@sajagana
[ignore] Rebased with latest master to include append_update_ops_data
2dedfcf
@sajagana
[ignore] Removed ENABLED_DISABLED_BOOLEAN_MAP from constants.py file
d87db55
@sajagana
[ignore] Changed the variable names in ndo_l3out_interface_routing_po…
3c4025a 
…licy module
@sajagana
[ignore] Moved bfd_multi_hop_settings argument spec to the module uti…
44754af 
…ls mso.py
@sajagana
[ignore] Added seealso section to the ndo_l3out_interface_routing_pol…
d74e155 
…icy and ndo_l3out_node_routing_policy modules
@sajagana sajagana dismissed stale reviews from samiib and akinross via d74e155 December 17, 2024 15:10
@sajagana sajagana force-pushed the 458_l3out_interface_routing_policy branch from 5a46157 to d74e155 Compare December 17, 2024 15:10
shrsr
shrsr approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrsr shrsr shrsr approved these changes

@samiib samiib samiib left review comments

@akinross akinross akinross left review comments

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for L3Out Interface Routing Policy in Tenant Tenant Policies Template (DCNE-132)
6 participants
@sajagana @shrsr @akinross @anvitha-jain @samiib @gmicol