Skip to content

Commit

Permalink
[ignore] fixed new sanity issue with typecheck
Browse files Browse the repository at this point in the history
  • Loading branch information
samiib authored and lhercot committed May 6, 2024
1 parent 65f2a9d commit ebf25f7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/galaxy-importer.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ RUN_ANSIBLE_LINT = True
RUN_ANSIBLE_TEST = False
ANSIBLE_TEST_LOCAL_IMAGE = False
LOCAL_IMAGE_DOCKER = False
INFRA_OSD = False
CHECK_CHANGELOG = False
INFRA_OSD = False
4 changes: 2 additions & 2 deletions plugins/module_utils/mso.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def issubset(subset, superset):
return False

# Item has different types in subset and superset
if type(superset.get(key)) != type(value):
if not isinstance(superset.get(key), type(value)):
return False

# Compare if item values are subset
Expand Down Expand Up @@ -849,7 +849,7 @@ def lookup_roles(self, roles, ignore_not_found_error=False):
access_type = "readWrite"
try:
role = ast.literal_eval(role)
if type(role) is dict and "name" in role:
if isinstance(role, dict) and "name" in role:
name = role.get("name")
if role.get("access_type") == "read":
access_type = "readOnly"
Expand Down

0 comments on commit ebf25f7

Please sign in to comment.