EpTemplate() - remove template_name validation #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpTemplate() was using FabricTypes() to validate the template_name property against a list of valid and supported fabric templates. However, the intent of EpTemplate() is to retrieve other template types as well (network, vrf, etc), so this validation isn't ideal in this larger context. This commit removes this validation and the associated import and instantiation of FabricTypes. There may be associated unit-tests that need to be updated. Will investigate and handle in a second commit if so.
1. Remove test_ep_templates_00050() This test validated that a ValueError is raised if template_name is invalid. The test for validity entailed comparing against a list of fabric template names in FabricTypes(). However, EpTemplate() is now responsible for retrieving templates that are not in this list (e.g. interface templates, etc). Hence, this test is no longer valid.
mikewiebe
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EpTemplate() used FabricTypes() to validate the template_name property against a list of supported fabric templates. However, the intent of EpTemplate() is to retrieve other template types as well (interface, network, vrf, etc), so this validation isn't ideal in this larger context.
Changes
Removes this validation and the associated import and instantiation of FabricTypes().
Removes unit test that verified a ValueError is raised if template_name did not match one of the templates in FabricTypes().