Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #206 : Removed "subscribed to mail" data from others profile #213

Merged

Conversation

noman2002
Copy link
Contributor

Fixes #206

Describe the changes you have made in this PR -
Removed "Subscribe to mail" data from others' profiles.

Screenshots of the changes (If any) -
My Profile:

Others profile-

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@noman2002 noman2002 changed the title Fixes: #206 : Removed "subscribed to mail" data for others profile Fixes: #206 : Removed "subscribed to mail" data from others profile Mar 16, 2022
@noman2002
Copy link
Contributor Author

Please re-run the workflow as it failed at flutter pub get only.

Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to find a better way to achieve the same result. Hint: if-else is possible in Dart Lists.

@aman-singh7 aman-singh7 force-pushed the subscribe-to-mail-issue-#206 branch from 2dfe2fb to 4d723e9 Compare June 5, 2022 00:40
@aman-singh7 aman-singh7 requested a review from manjotsidhu June 5, 2022 00:49
@aman-singh7
Copy link
Member

@manjotsidhu requested changes are done.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2441414477

  • 14 of 28 (50.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 70.55%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/ib/ib_landing_view.dart 0 1 0.0%
lib/viewmodels/ib/ib_page_viewmodel.dart 0 1 0.0%
lib/viewmodels/profile/profile_viewmodel.dart 5 9 55.56%
lib/ui/views/ib/builders/ib_webview_builder.dart 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
lib/ui/views/ib/ib_landing_view.dart 1 66.67%
Totals Coverage Status
Change from base Build 2220860365: -0.07%
Covered Lines: 3912
Relevant Lines: 5545

💛 - Coveralls

analysis_options.yaml Show resolved Hide resolved
@manjotsidhu manjotsidhu merged commit 83923a7 into CircuitVerse:master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Subscribe to mail" data from others profile.
4 participants