Skip to content

Commit

Permalink
New Rules(Remove empty line not required before block comment exclude…
Browse files Browse the repository at this point in the history
…d and Todo.CommentFound enabled)
  • Loading branch information
amritcheema25 committed Jan 22, 2018
1 parent c0fc890 commit d2f6b78
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
<!-- Yeah... we need to be able to concat strings! -->
<exclude name="Generic.Strings.UnnecessaryStringConcat.Found"/>

<!-- Remove empty line not required before block comment -->
<exclude name="Squiz.Commenting.BlockComment.NoEmptyLineBefore"/>

<!-- Blank lines are ok after comments, control structures, and case/defaults, right? -->
<exclude name="Squiz.Commenting.InlineComment.SpacingAfter"/>
<exclude name="WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterEnd"/>
Expand Down Expand Up @@ -166,11 +169,11 @@
-->

<!-- TODO: It would be good to add this sniff as well, but it doesn't seem to work yet. -->
<!--

<rule ref="Generic.Commenting.Todo.CommentFound">
<severity>5</severity>
</rule>
-->


<!-- TODO: We also want to force spaces after commas in method calls, but there doesn't seem to be
a sniff for this yet. -->
Expand Down

2 comments on commit d2f6b78

@tdmalone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amritcheema25, could you also remove the TODO comment above Todo.CommentFound? It's confusing that it's still there when the rule is enabled. Thanks!

@amritcheema25
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 432e677

Please sign in to comment.