Merge pull request #19 from ChoTotOSS/feat/adjust-rules

adjust rules for supporting parameter properties
ChoTotOSS · Jun 22, 2023 · 6a4466d · 6a4466d
2 parents f32ee30 + a05ccaf
commit 6a4466d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/few-cooks-grin.md b/.changeset/few-cooks-grin.md
@@ -0,0 +1,5 @@
+---
+'@chotot/eslint-config-next': patch
+---
+
+adjust rules for supporting parameter property
diff --git a/packages/eslint-config-next/index.js b/packages/eslint-config-next/index.js
@@ -61,7 +61,7 @@ module.exports = {
     'no-empty-function': [
       'error',
       {
-        allow: ['arrowFunctions', 'functions', 'methods'],
+        allow: ['arrowFunctions', 'functions', 'methods', 'constructors'],
       },
     ],
     // Disallow empty destructuring patterns
@@ -431,7 +431,7 @@ module.exports = {
     'no-useless-computed-key': 'error',
     // Disallow unnecessary constructors
     // https://eslint.org/docs/latest/rules/no-useless-constructor
-    'no-useless-constructor': 'error',
+    'no-useless-constructor': 'off',
     // Disallow renaming import, export, and destructured assignments to the same name
     // https://eslint.org/docs/latest/rules/no-useless-rename
     'no-useless-rename': [
@@ -1638,7 +1638,7 @@ module.exports = {
         '@typescript-eslint/non-nullable-type-assertion-style': 'error',
         // Require or disallow parameter properties in class constructors.
         // https://typescript-eslint.io/rules/parameter-properties
-        '@typescript-eslint/parameter-properties': 'error',
+        '@typescript-eslint/parameter-properties': 'off',
         // Enforce the use of as const over literal type.
         // https://typescript-eslint.io/rules/prefer-as-const
         '@typescript-eslint/prefer-as-const': 'error',