Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark behavior #631

Closed
wants to merge 3 commits into from
Closed

Fix benchmark behavior #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
850d2c4
Fix benchmark behavior
Rigidity Jul 30, 2024
06587e0
Move setup into iter
Rigidity Jul 30, 2024
4b85a16
Make sure the benchmarks are accurate
Rigidity Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions crates/chia-bls/benches/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,41 +24,49 @@ fn cache_benchmark(c: &mut Criterion) {
}

let bls_cache = BlsCache::default();

c.bench_function("bls_cache.aggregate_verify, 0% cache hits", |b| {
b.iter(|| {
let bls_cache = bls_cache.clone();
assert!(bls_cache.aggregate_verify(pks.iter().zip([&msg].iter().cycle()), &agg_sig));
});
});

// populate 10% of keys
let bls_cache = BlsCache::default();
bls_cache.aggregate_verify(pks[0..100].iter().zip([&msg].iter().cycle()), &agg_sig);
c.bench_function("bls_cache.aggregate_verify, 10% cache hits", |b| {
b.iter(|| {
let bls_cache = bls_cache.clone();
assert!(bls_cache.aggregate_verify(pks.iter().zip([&msg].iter().cycle()), &agg_sig));
});
});

// populate another 10% of keys
bls_cache.aggregate_verify(pks[100..200].iter().zip([&msg].iter().cycle()), &agg_sig);
let bls_cache = BlsCache::default();
bls_cache.aggregate_verify(pks[0..200].iter().zip([&msg].iter().cycle()), &agg_sig);
c.bench_function("bls_cache.aggregate_verify, 20% cache hits", |b| {
b.iter(|| {
let bls_cache = bls_cache.clone();
assert!(bls_cache.aggregate_verify(pks.iter().zip([&msg].iter().cycle()), &agg_sig));
});
});

// populate another 30% of keys
bls_cache.aggregate_verify(pks[200..500].iter().zip([&msg].iter().cycle()), &agg_sig);
let bls_cache = BlsCache::default();
bls_cache.aggregate_verify(pks[0..500].iter().zip([&msg].iter().cycle()), &agg_sig);
c.bench_function("bls_cache.aggregate_verify, 50% cache hits", |b| {
b.iter(|| {
let bls_cache = bls_cache.clone();
assert!(bls_cache.aggregate_verify(pks.iter().zip([&msg].iter().cycle()), &agg_sig));
});
});

// populate all other keys
bls_cache.aggregate_verify(pks[500..1000].iter().zip([&msg].iter().cycle()), &agg_sig);
let bls_cache = BlsCache::default();
bls_cache.aggregate_verify(pks[0..1000].iter().zip([&msg].iter().cycle()), &agg_sig);
c.bench_function("bls_cache.aggregate_verify, 100% cache hits", |b| {
b.iter(|| {
let bls_cache = bls_cache.clone();
assert!(bls_cache.aggregate_verify(pks.iter().zip([&msg].iter().cycle()), &agg_sig));
});
});
Expand Down
8 changes: 8 additions & 0 deletions crates/chia-bls/src/bls_cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ pub struct BlsCache {
cache: Mutex<LruCache<[u8; 32], GTElement>>,
}

impl Clone for BlsCache {
fn clone(&self) -> Self {
Self {
cache: Mutex::new(self.cache.lock().clone()),
}
}
}

impl Default for BlsCache {
fn default() -> Self {
Self::new(NonZeroUsize::new(50000).unwrap())
Expand Down
Loading