Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch rust wrapper for sqlite in chia-tools #331

Merged
merged 1 commit into from
Dec 5, 2023
Merged

switch rust wrapper for sqlite in chia-tools #331

merged 1 commit into from
Dec 5, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 4, 2023

rusqlite appears to be much more established and popular in the rust ecosystem. But more importantly, it has much more complete support for sqlite features, which are required for the event-log analysis tool I'm building.

While working in these files, I took the opportunity to transition test_block_generators.rs to use the (somewhat new) higher level abstraction to iterate over the transaction blocks in a blockchain database. This reduces a fair amount of duplicated code.

Copy link

coveralls-official bot commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7098705134

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 86.156%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia-tools/src/visit_spends.rs 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
chia-tools/src/visit_spends.rs 1 0.0%
Totals Coverage Status
Change from base Build 7093492066: -0.2%
Covered Lines: 10878
Relevant Lines: 12626

💛 - Coveralls

@arvidn arvidn merged commit 7e5996e into main Dec 5, 2023
54 checks passed
@arvidn arvidn deleted the rusqlite branch December 5, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants