Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the parameter name of from_json_dict() to match python #323

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 26, 2023

This allows calling from_json_dict() with a named argument, like: from_json_dict(json_dict=obj).

For example: https://github.com/Chia-Network/chia-blockchain/blob/main/tests/wallet/rpc/test_wallet_rpc.py#L1529

@arvidn arvidn marked this pull request as ready for review November 26, 2023 00:14
Copy link

Pull Request Test Coverage Report for Build 6992171724

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 85.827%

Totals Coverage Status
Change from base Build 6984633742: 0.001%
Covered Lines: 9986
Relevant Lines: 11635

💛 - Coveralls

@arvidn arvidn requested a review from AmineKhaldi November 27, 2023 12:46
@cmmarslender cmmarslender merged commit e88b6e5 into main Nov 27, 2023
53 checks passed
@cmmarslender cmmarslender deleted the json-dict-arg-name branch November 27, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants