Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename clvm-derive representations #316

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Rename clvm-derive representations #316

merged 5 commits into from
Nov 17, 2023

Conversation

Rigidity
Copy link
Contributor

No description provided.

arvidn
arvidn previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit if you thin it's worth addressing

clvm-derive/src/helpers.rs Outdated Show resolved Hide resolved
@Rigidity Rigidity requested a review from arvidn November 16, 2023 23:01
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6897499011

  • 28 of 35 (80.0%) changed or added relevant lines in 4 files are covered.
  • 11 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.07%) to 85.826%
Changes Missing Coverage Covered Lines Changed/Added Lines %
clvm-derive/src/helpers.rs 16 23 69.57%
Files with Coverage Reduction New Missed Lines %
chia-protocol/src/coin.rs 1 98.25%
chia-protocol/src/message_struct.rs 1 28.57%
clvm-derive/src/helpers.rs 1 67.44%
wheel/src/run_program.rs 1 69.44%
wheel/src/run_generator.rs 2 83.11%
wheel/src/api.rs 5 68.65%
Totals Coverage Status
Change from base Build 6799173174: 0.07%
Covered Lines: 9985
Relevant Lines: 11634
💛 - Coveralls

@cmmarslender cmmarslender merged commit 40885a2 into Chia-Network:main Nov 17, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
ready_to_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rigidity @arvidn @cmmarslender