Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize Vec<T>::parse(), for Streamable #313

Merged
merged 2 commits into from
Nov 8, 2023
Merged

optimize Vec<T>::parse(), for Streamable #313

merged 2 commits into from
Nov 8, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 4, 2023

by pre-allocating its size

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6797367876

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 85.755%
Totals Coverage Status
Change from base Build 6744260326: 0.03%
Covered Lines: 10017
Relevant Lines: 11681
💛 - Coveralls

@arvidn arvidn requested a review from AmineKhaldi November 6, 2023 12:34
@arvidn arvidn force-pushed the optimize-parse-vec branch from 54249e2 to 3e601ca Compare November 8, 2023 10:47
@arvidn arvidn force-pushed the optimize-parse-vec branch from 3e601ca to 7c399de Compare November 8, 2023 10:48
@arvidn arvidn changed the title optimize Vec<T>::parse(), for Streeamable optimize Vec<T>::parse(), for Streamable Nov 8, 2023
@arvidn arvidn force-pushed the optimize-parse-vec branch from e9e249d to 666850c Compare November 8, 2023 10:59
@arvidn arvidn force-pushed the optimize-parse-vec branch from 666850c to a419156 Compare November 8, 2023 11:08
@arvidn arvidn merged commit b5b2653 into main Nov 8, 2023
55 checks passed
@arvidn arvidn deleted the optimize-parse-vec branch November 8, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity left review comments

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @AmineKhaldi @Rigidity