Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make from_bytes() accept python's buffer API #306

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 29, 2023

otherwise it's not possible to directly pass in a slice of a bytes object. i.e. .from_bytes(b[1:]). It would have to be copied into a new bytes object first, i.e. .from_bytes(bytes(b[1:]))

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 6685348061

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 86.554%

Totals Coverage Status
Change from base Build 6684093624: 0.008%
Covered Lines: 9739
Relevant Lines: 11252

💛 - Coveralls

@arvidn arvidn requested a review from AmineKhaldi October 30, 2023 09:12
@arvidn arvidn merged commit e0d4d15 into main Oct 30, 2023
54 checks passed
@arvidn arvidn deleted the from-bytes-buffer branch October 30, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants