Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup riscv workflow #265

Merged
merged 10 commits into from
Oct 11, 2023
Merged

Setup riscv workflow #265

merged 10 commits into from
Oct 11, 2023

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Sep 7, 2023

No description provided.

@coveralls-official
Copy link

coveralls-official bot commented Sep 7, 2023

Pull Request Test Coverage Report for Build 6241875413

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.105%

Totals Coverage Status
Change from base Build 6113022885: 0.0%
Covered Lines: 8583
Relevant Lines: 9421

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Sep 10, 2023

in an ideal world you would also run cargo test --all --release

@emlowe
Copy link
Contributor Author

emlowe commented Sep 20, 2023

Takes 2 hours under QEMU to run cargo build --release && cargo test && cargo test --release
Do we need to do the build or is the single cargo test --release ok?

@arvidn
Copy link
Contributor

arvidn commented Sep 22, 2023

Do we need to do the build or is the single cargo test --release ok?

That will both build and run the tests. I would think that's sufficient, especially since it's just for this architecture.

There are some pretty expensive tests, that's why it's good to run in release mode. Alternatively, there might be a way to exclude the generator tests (which are essentially stress tests)

@emlowe
Copy link
Contributor Author

emlowe commented Sep 25, 2023

Undraft - takes about 30 mins to build and test the crate as well as build the wheel - parallel jobs though so total time is about 30m

@emlowe emlowe marked this pull request as ready for review September 25, 2023 23:34
@arvidn arvidn merged commit dd97916 into main Oct 11, 2023
54 checks passed
@arvidn arvidn deleted the EL.riscv branch October 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants