Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): display select properly #51

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

Sukaato
Copy link
Member

@Sukaato Sukaato commented Sep 29, 2024

popover property cause this bug since element extends HTMLElement under the hood Also fix the lable

fixes: #41


What is the current behavior?

select open in popover HTML style on click

What is the new behavior?

  • The select is displayed properly and on in HTML popover
  • The labal has now the same style on every form component

Does this introduce a breaking change?

  • Yes
  • No

Other information

`popover` property cause this bug since element extends HTMLElement under the hood
Also fix the lable

fixes: #41
@Sukaato Sukaato requested a review from Xenxia September 29, 2024 10:55
@github-actions github-actions bot added bug Something isn't working package: core @poppy-ui/core package related labels Sep 29, 2024
@Sukaato Sukaato merged commit 9951a4b into main Sep 29, 2024
16 checks passed
@Sukaato Sukaato deleted the fix/41-pop-select-render branch September 29, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core @poppy-ui/core package related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug (core/vue): pop-select not rendered correctly
2 participants