Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): fix button css #33

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

Sukaato
Copy link
Member

@Sukaato Sukaato commented Sep 7, 2024

remove border-color transparent to fix button css
add basic test html file for manual test

fixes: #27


What is the current behavior?

What is the new behavior?

  • outinled disabled button now have border

Does this introduce a breaking change?

  • Yes
  • No

Other information

remove border-color transparent to fix button css
add basic test html file for manual test

fixes: #27
@github-actions github-actions bot added bug Something isn't working package: core @poppy-ui/core package related labels Sep 7, 2024
@Sukaato Sukaato requested a review from Xenxia September 7, 2024 10:13
@Sukaato Sukaato merged commit fa5786c into main Sep 7, 2024
13 checks passed
@Sukaato Sukaato deleted the fix/button-outlined-disabled-is-hidden branch September 7, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core @poppy-ui/core package related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug (core): pop-button is not display when outlined & disabled are true
2 participants