Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix undefined resize observer #32

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

Sukaato
Copy link
Member

@Sukaato Sukaato commented Sep 6, 2024

resize observer can be null when loading

fixes: #29


What is the current behavior?

When the component load on vue app, sometimes the disconnect hook is called, and when its called, the resize observer is undefined

What is the new behavior?

  • Check if the resize observer is undefined before disconnect it
  • update the doc

Does this introduce a breaking change?

  • Yes
  • No

Other information

@Sukaato Sukaato changed the title fix(textarea): fix undefined resize observer fix(core): fix undefined resize observer Sep 6, 2024
@github-actions github-actions bot added bug Something isn't working package: core @poppy-ui/core package related labels Sep 6, 2024
resize observer can be null when loading

fixes: #29
@Sukaato Sukaato added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Sep 7, 2024
@Sukaato Sukaato merged commit b05e9aa into main Sep 7, 2024
13 checks passed
@Sukaato Sukaato deleted the fix/textarea-error branch September 7, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation package: core @poppy-ui/core package related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug (core): textarea resizeobserver
1 participant