Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawer): add events #25

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat(drawer): add events #25

merged 1 commit into from
Aug 28, 2024

Conversation

Sukaato
Copy link
Member

@Sukaato Sukaato commented Aug 28, 2024

Add popDidPresent and popDidDismiss event

fixes: #18

What is the current behavior?

Drawer does not emit event when it open or close

What is the new behavior?

  • Emit popDidPresent event when the drawer is opened.
  • Emit popDidDismiss event when the drawer is closed.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added features New feature or request package: vue @poppy-ui/vue package related package: core @poppy-ui/core package related labels Aug 28, 2024
@Sukaato Sukaato force-pushed the feat/drawer-events branch from 8e5b336 to 0d8596e Compare August 28, 2024 11:48
@Sukaato Sukaato force-pushed the feat/drawer-events branch from 0d8596e to 2fff472 Compare August 28, 2024 12:01
@Sukaato Sukaato force-pushed the feat/drawer-events branch from 2fff472 to ecca2ef Compare August 28, 2024 12:06
Add popDidPresent and popDidDismiss event

fixes: #18
@Sukaato Sukaato force-pushed the feat/drawer-events branch from ecca2ef to aae233b Compare August 28, 2024 12:19
@Sukaato Sukaato merged commit ccc8707 into main Aug 28, 2024
20 checks passed
@Sukaato Sukaato deleted the feat/drawer-events branch August 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features New feature or request package: core @poppy-ui/core package related package: vue @poppy-ui/vue package related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat (core): Add drawer custom event
1 participant