Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(modal): complete the modal doc #24

Merged
merged 1 commit into from
Aug 27, 2024
Merged

docs(modal): complete the modal doc #24

merged 1 commit into from
Aug 27, 2024

Conversation

Sukaato
Copy link
Member

@Sukaato Sukaato commented Aug 27, 2024

fixes: #20


What is the current behavior?

Modal doc is not complete

What is the new behavior?

  • Complete the modal doc

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added documentation Improvements or additions to documentation package: core @poppy-ui/core package related labels Aug 27, 2024
@Sukaato Sukaato requested a review from Xenxia August 27, 2024 18:56
@Sukaato Sukaato force-pushed the docs/complete-modal branch from f7d9908 to f059d79 Compare August 27, 2024 18:58
Copy link
Member

@Xenxia Xenxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@Sukaato Sukaato merged commit 2e02060 into main Aug 27, 2024
13 checks passed
@Sukaato Sukaato deleted the docs/complete-modal branch August 27, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation package: core @poppy-ui/core package related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug (core): documentation not complete on modal
2 participants