Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (core): Add drawer custom event #18

Closed
3 tasks done
Sukaato opened this issue Aug 25, 2024 · 0 comments · Fixed by #25
Closed
3 tasks done

feat (core): Add drawer custom event #18

Sukaato opened this issue Aug 25, 2024 · 0 comments · Fixed by #25
Assignees
@Sukaato
Labels
features New feature or request package: core @poppy-ui/core package related
Milestone
v1.0.0

Comments

@Sukaato
Copy link
Member

Sukaato commented Aug 25, 2024

Prerequisites

Describe the Feature Request

Add custom event on drawer to indicate the drawer has dismiss

Describe the Use Case

I use the hash in the url to indicate if the drawer is open or not, on close i can not handle the closing state without a lot of code

Describe Preferred Solution

  • Add PopPresent event on open
  • Add PopDismiss event on close

Describe Alternatives

No response

Related Code

No response

Additional Information

No response
@Sukaato Sukaato added the features New feature or request label Aug 25, 2024
@Sukaato Sukaato self-assigned this Aug 25, 2024
@github-actions github-actions bot added the package: core @poppy-ui/core package related label Aug 25, 2024
@Sukaato Sukaato added this to the v1.0.0 milestone Aug 25, 2024
@Sukaato Sukaato changed the title feat (core): Add custom event feat (core): Add drawer custom event Aug 26, 2024
Sukaato added a commit that referenced this issue Aug 28, 2024
@Sukaato
feat(drawer): add events
8e5b336 
Add popDidPresent and popDidDismiss event

fixes: #18
@Sukaato Sukaato mentioned this issue Aug 28, 2024
Merged
2 tasks
Sukaato added a commit that referenced this issue Aug 28, 2024
@Sukaato
feat(drawer): add events
0d8596e 
Add popDidPresent and popDidDismiss event

fixes: #18
Sukaato added a commit that referenced this issue Aug 28, 2024
@Sukaato
feat(drawer): add events
2fff472 
Add popDidPresent and popDidDismiss event

fixes: #18
Sukaato added a commit that referenced this issue Aug 28, 2024
@Sukaato
feat(drawer): add events
ecca2ef 
Add popDidPresent and popDidDismiss event

fixes: #18
Sukaato added a commit that referenced this issue Aug 28, 2024
@Sukaato
feat(drawer): add events
aae233b 
Add popDidPresent and popDidDismiss event

fixes: #18
Sukaato added a commit that referenced this issue Aug 28, 2024
@Sukaato
feat(drawer): add events
ccc8707 
Add popDidPresent and popDidDismiss event

fixes: #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sukaato Sukaato

Labels
features New feature or request package: core @poppy-ui/core package related
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

feat(drawer): add events CheeseGrinder/poppy-ui
1 participant
@Sukaato