Skip to content

Commit

Permalink
Updated deployWithPublicIPs property
Browse files Browse the repository at this point in the history
  • Loading branch information
chkp-olgami committed Apr 10, 2024
1 parent 96d11a8 commit c819e6f
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions gcp/deployment-packages/ha-byol/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ To deploy the Deployment Manager's package manually, without using the GCP Marke
| | | | | |
| **shell** | Admin shell | string | /etc/cli.sh;<br/>/bin/bash;<br/>/bin/csh;<br/>/bin/tcsh;<br/> |
| | | | | |
| **deployWithoutPublicIPs** | Deploy HA without public IPs | boolean | true; <br/>false; |
| **deployWithPublicIPs** | Deploy HA with public IPs | boolean | true; <br/>false; |
| | | | | |
| **instanceSSHKey** | Public SSH key for the user 'admin' | string | A valid public ssh key |
| | | | | |
Expand Down Expand Up @@ -151,7 +151,7 @@ To deploy the Deployment Manager's package manually, without using the GCP Marke
generatePassword: false
allowUploadDownload: false
shell: "/bin/bash"
deployWithoutPublicIPs: true
deployWithPublicIPs: true
cluster-network-cidr: "10.0.1.0/24"
cluster-network-name: "external-vpc"
cluster-network-subnetwork-name: "frontend"
Expand Down
4 changes: 2 additions & 2 deletions gcp/deployment-packages/ha-byol/check-point-cluster--byol.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def make_static_address(prop, name):

def create_external_addresses_if_needed(
prop, resources, member_a_nics, member_b_nics):
if prop['deployWithoutPublicIPs']:
if not prop['deployWithPublicIPs']:
prop['primary_cluster_address_name'] = NO_PUBLIC_IP
prop['secondary_cluster_address_name'] = NO_PUBLIC_IP
else:
Expand Down Expand Up @@ -472,7 +472,7 @@ def generate_config(context):
}
]

if not prop['deployWithoutPublicIPs']:
if prop['deployWithPublicIPs']:
outputs += [
{
'name': 'clusterIP',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ properties:
gceMachineType:
minCpu: 2
minRamGb: 1.843000054359436
deployWithoutPublicIPs:
deployWithPublicIPs:
type: boolean
default: False
default: True
instanceSSHKey:
type: string
pattern: ^([0-9a-z\-]+ +[0-9A-Za-z/\+=]+( .*)?|)$
Expand Down
2 changes: 1 addition & 1 deletion gcp/deployment-packages/ha-byol/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ resources:
generatePassword: "PLEASE ENTER true or false"
allowUploadDownload: "PLEASE ENTER true or false"
shell: "PLEASE ENTER A SHELL"
deployWithoutPublicIPs: "PLEASE ENTER true or false"
deployWithPublicIPs: "PLEASE ENTER true or false"
cluster-network-cidr: "PLEASE ENTER CLUSTER NETWORK CIDR"
cluster-network-name: "PLEASE ENTER CLUSTER NETWORK ID"
cluster-network-subnetwork-name: "PLEASE ENTER CLUSTER SUBNETWORK ID"
Expand Down
4 changes: 2 additions & 2 deletions gcp/deployment-packages/ha-payg/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ To deploy the Deployment Manager's package manually, without using the GCP Marke
| | | | | |
| **shell** | Admin shell | string | /etc/cli.sh;<br/>/bin/bash;<br/>/bin/csh;<br/>/bin/tcsh;<br/> |
| | | | | |
| **deployWithoutPublicIPs** | Deploy HA without public IPs | boolean | true; <br/>false; |
| **deployWithPublicIPs** | Deploy HA with public IPs | boolean | true; <br/>false; |
| | | | | |
| **instanceSSHKey** | Public SSH key for the user 'admin' | string | A valid public ssh key |
| | | | | |
Expand Down Expand Up @@ -151,7 +151,7 @@ To deploy the Deployment Manager's package manually, without using the GCP Marke
generatePassword: false
allowUploadDownload: false
shell: "/bin/bash"
deployWithoutPublicIPs: true
deployWithPublicIPs: true
cluster-network-cidr: "10.0.1.0/24"
cluster-network-name: "external-vpc"
cluster-network-subnetwork-name: "frontend"
Expand Down
4 changes: 2 additions & 2 deletions gcp/deployment-packages/ha-payg/check-point-cluster--payg.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def make_static_address(prop, name):

def create_external_addresses_if_needed(
prop, resources, member_a_nics, member_b_nics):
if prop['deployWithoutPublicIPs']:
if not prop['deployWithPublicIPs']:
prop['primary_cluster_address_name'] = NO_PUBLIC_IP
prop['secondary_cluster_address_name'] = NO_PUBLIC_IP
else:
Expand Down Expand Up @@ -472,7 +472,7 @@ def generate_config(context):
}
]

if not prop['deployWithoutPublicIPs']:
if prop['deployWithPublicIPs']:
outputs += [
{
'name': 'clusterIP',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ properties:
gceMachineType:
minCpu: 2
minRamGb: 1.843000054359436
deployWithoutPublicIPs:
deployWithPublicIPs:
type: boolean
default: False
default: True
instanceSSHKey:
type: string
pattern: ^([0-9a-z\-]+ +[0-9A-Za-z/\+=]+( .*)?|)$
Expand Down
2 changes: 1 addition & 1 deletion gcp/deployment-packages/ha-payg/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ resources:
generatePassword: "PLEASE ENTER true or false"
allowUploadDownload: "PLEASE ENTER true or false"
shell: "PLEASE ENTER A SHELL"
deployWithoutPublicIPs: "PLEASE ENTER true or false"
deployWithPublicIPs: "PLEASE ENTER true or false"
cluster-network-cidr: "PLEASE ENTER CLUSTER NETWORK CIDR"
cluster-network-name: "PLEASE ENTER CLUSTER NETWORK ID"
cluster-network-subnetwork-name: "PLEASE ENTER CLUSTER SUBNETWORK ID"
Expand Down

0 comments on commit c819e6f

Please sign in to comment.