Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Emoji v13 (2020) #1555

Merged
merged 14 commits into from
Feb 13, 2021
Merged

Update to Emoji v13 (2020) #1555

merged 14 commits into from
Feb 13, 2021

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Feb 15, 2020

The plan is to:

  • Update the emoji stuff to support Unicode 12.1 emojis and their new tone stuff
  • Upload emojis to a proper CDN instead of using a random server

@RAnders00
Copy link
Collaborator

RAnders00 commented Feb 23, 2020 •
edited
Loading

https://www.jsdelivr.com/package/npm/emoji-datasource-twitter?path=img%2Ftwitter%2F64 twitter emojis are on jsdelivr too as far as i can see
Also apple: https://www.jsdelivr.com/package/npm/emoji-datasource-apple

@RAnders00
Copy link
Collaborator

An issue I've found: Some modifiers are not rendered as images when there are images for them, for example 🦲 (EMOJI COMPONENT BALD) renders as https://abs-0.twimg.com/emoji/v2/svg/1f9b2.svg when used on twitter.com (used as a reference for their Twitter set of emoji images) however in chatterino it does not render:
image

Emojipedia also lists the twitter image for the "bald" modifier alone: https://emojipedia.org/bald/
image

@zneix
Copy link
Collaborator

zneix commented Sep 4, 2020

Fixing this would close #869

@ALazyMeme
Copy link
Collaborator

Hello any news on this pr? I'm patiently waiting to use the pinching hand emoji in chatterino 🤏

@fourtf
Copy link
Member

fourtf commented Sep 26, 2020

Is this still being worked on or can I close?

@pajlada
Copy link
Member Author

pajlada commented Sep 26, 2020

Leave this up

@ALazyMeme
Copy link
Collaborator

Looking forward to using the new emojis in chatterino 😁

@ALazyMeme
Copy link
Collaborator

New year, new emojis 😄 can't wait for this to be implemented!

@ALazyMeme
Copy link
Collaborator

ALazyMeme commented Jan 18, 2021 •
edited
Loading

Can't wait to prove these nerds wrong when I can see the window emoji 😲

image

@Mm2PL
Copy link
Collaborator

Mm2PL commented Feb 11, 2021

Can't wait for this to be merged

@pajlada pajlada force-pushed the pajlada-update-emojis branch from 2788228 to 26bc06f Compare February 11, 2021 12:45
@pajlada pajlada force-pushed the pajlada-update-emojis branch from b4268a4 to 0f08b28 Compare February 12, 2021 11:37
@pajlada
Update emoji to version 13 (2020)
4623e07 
Remove EmojiOne 2 and EmojiOne 3 due to license changes (a bit overdue)

Default Emoji set changed from EmojiOne 2 to Twitter
@pajlada
Remove emojidata.txt from resources
df38735
@pajlada
Merge branch 'master' into pajlada-update-emojis
ece19f5
@pajlada pajlada marked this pull request as ready for review February 12, 2021 13:49
zneix
zneix requested changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, new emojis work fine. Worth noting there's a very slow emoji load at the first launch, but since it seems to be cached and loads quicker later I guess it's fine 👍

src/providers/emoji/Emojis.cpp Outdated Show resolved Hide resolved
@pajlada
Copy link
Member Author

pajlada commented Feb 12, 2021

Looks good to me, new emojis work fine. Worth noting there's a very slow emoji load at the first launch, but since it seems to be cached and loads quicker later I guess it's fine +1

Thanks for the review!
The slow speed is at least just as slow as it's been before, not slower, as it's hosted on the same provider & server and the filesizes are very similar for these set of emojis.

Still interested in finding a "true CDN" that isn't slow af, but the b2+cloudflare combo was megaslow

@ALazyMeme
Copy link
Collaborator

We stopped using JoyPixels didn't we? Was looking at a basic CDN like this: https://cdnjs.com/libraries/emoji-toolkit

@pajlada
Copy link
Member Author

pajlada commented Feb 13, 2021

We stopped using JoyPixels didn't we? Was looking at a basic CDN like this: https://cdnjs.com/libraries/emoji-toolkit

We did, yes

@pajlada
Copy link
Member Author

pajlada commented Feb 13, 2021

Waiting for #2453 to be merged in before running final tests on this and merging it

@pajlada pajlada force-pushed the pajlada-update-emojis branch from 8f4126b to 705b0d5 Compare February 13, 2021 18:04
@pajlada pajlada changed the title Update emojis Update to Emoji v13 (2020) Feb 13, 2021
@pajlada pajlada merged commit 6b0ce39 into master Feb 13, 2021
@pajlada pajlada deleted the pajlada-update-emojis branch February 13, 2021 18:17
@pajlada pajlada mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zneix zneix zneix requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pajlada @RAnders00 @zneix @ALazyMeme @fourtf @Mm2PL