-
Notifications
You must be signed in to change notification settings - Fork 59.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use current session id to trigger rerender #5812
Conversation
@Dogtiti is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
close #5792 |
close #5792 |
修复新增聊天总是将currentSessionIndex设置为0 导致key没有变化所以组件没有重新卸载渲染导致的一系列相关问题 |
Fixed a series of related problems caused by always setting the currentSessionIndex to 0 when adding new chats, resulting in the key not changing and the component not being re-unloaded and rendered. |
Your build has completed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/components/chat.tsx (1)
2074-2075
: LGTM! Improved component stability using session ID.The change from using an index to using the session's unique ID as the React key prop is a good improvement. This ensures stable component identity across rerenders and prevents potential issues with index-based keying when sessions are reordered or removed.
Consider adding a type annotation for better code clarity:
export function Chat() { - const session = chatStore.currentSession(); + const session: ChatSession = chatStore.currentSession(); return <_Chat key={session.id}></_Chat>; }
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information
Summary by CodeRabbit
Chat
component to access the current session more reliably by using a unique session identifier.