-
Notifications
You must be signed in to change notification settings - Fork 59.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUSTOM_MODELS - support wildcard and entire providerName #5160
base: main
Are you sure you want to change the base?
Conversation
@bestsanmao is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent changes enhance the functionality of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/utils/model.ts (2 hunks)
Additional comments not posted (6)
app/utils/model.ts (6)
55-56
: Introducematch
variable to streamline logic.The introduction of the
match
variable simplifies the logic for determining if a model name matches the providedcustomModelName
andcustomProviderName
.
61-61
: Simplify matching logic.The simplified matching logic improves readability and maintainability.
63-74
: Enhance pattern matching with wildcards and exclusions.The added logic for handling wildcards and exclusions (
-
) enhances the flexibility of model specifications. However, ensure that the regular expression construction is efficient and correctly handles edge cases.Ensure that the regular expression correctly handles edge cases and does not introduce performance overhead.
76-76
: Setavailable
flag based on match.Setting the
available
flag based on thematch
variable is a clear and efficient approach.
119-119
: Improve consistency in quotation marks.The change to use consistent quotation marks improves code readability.
125-128
: Reformat logic for setting default model.The reformatted logic for setting a model as default is clearer and separates the checks for availability and matching against the
defaultModel
.
Your build has completed! |
#5050
for CUSTOM_MODELS
if start with "-", it supports -@providerName
and -modelname support wildcard (*),
eg:
CUSTOM_MODELS=-ernie-*,-doubao-*,-@azure